Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow trailing slashes in url #39

Closed
nadar opened this issue Feb 11, 2018 · 2 comments
Closed

Disallow trailing slashes in url #39

nadar opened this issue Feb 11, 2018 · 2 comments
Assignees
Labels

Comments

@nadar
Copy link
Member

nadar commented Feb 11, 2018

Now the cms url's are valid with trailing slash, but the cms url generator never returns urls with urlManger suffix. Therefore URLs with trailing slashes are invalid urls and 404 should be thrown.

@nadar nadar added the bug label Feb 11, 2018
@nadar nadar self-assigned this Feb 11, 2018
nadar added a commit that referenced this issue Feb 11, 2018
@rolandschaub
Copy link
Member

I don't think it should throw an error but redirect to the same URL without trailing slash (permanent redirection).

@nadar
Copy link
Member Author

nadar commented Mar 5, 2018

@rolandschaub you are right, but lets make another issue for this.

@nadar nadar closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants