Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-chinese-messages #19

Merged
merged 4 commits into from
Jan 5, 2018
Merged

add-chinese-messages #19

merged 4 commits into from
Jan 5, 2018

Conversation

baqianxin
Copy link
Contributor

添加中文翻译

@baqianxin
Copy link
Contributor Author

合并部分中文翻译分支

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 16.673% when pulling 166f2dd on baqianxin:luya-chinese-oom into 8e71985 on luyadev:master.

Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog entry here as well? And there are also a few words which are not translated, any reason for this?

Thanks for the translations anyhow!

@nadar
Copy link
Member

nadar commented Jan 3, 2018

@baqianxin I don't understand the chinese messages from above "添加中文翻译" and "合并部分中文翻译分支" please comment in english 😄 but with google translate i think i understand what you are saying

@nadar
Copy link
Member

nadar commented Jan 4, 2018

@baqianxin the changelog is still missing, i would like to merge this PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 16.673% when pulling cb1c762 on baqianxin:luya-chinese-oom into 8e71985 on luyadev:master.

@nadar nadar merged commit 28e997b into luyadev:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants