Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear cache for parent block #49

Merged
merged 2 commits into from
Mar 17, 2018
Merged

Clear cache for parent block #49

merged 2 commits into from
Mar 17, 2018

Conversation

boehsermoe
Copy link
Member

Edit a block which parent block is cacheable, will clear the parent cache now.

@coveralls
Copy link

coveralls commented Mar 17, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 16.815% when pulling 6d44378 on boehsermoe:master into 3623f2e on luyadev:master.

@nadar nadar self-assigned this Mar 17, 2018
nadar
nadar requested changes Mar 17, 2018
View reviewed changes
Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Thanks. Would you please add a changelog entry? After this your PR looks good to me, even when prev_id is empty should not be a problem.

@nadar nadar merged commit 47b137b into luyadev:master Mar 17, 2018
@nadar
Copy link
Member

nadar commented Mar 17, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadar nadar nadar requested changes

Assignees

@nadar nadar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boehsermoe @coveralls @nadar