Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme/create command with not working output #2020

Closed
JohnnyMcWeed opened this issue May 5, 2020 · 3 comments · Fixed by #2035
Closed

theme/create command with not working output #2020

JohnnyMcWeed opened this issue May 5, 2020 · 3 comments · Fixed by #2035
Assignees

Comments

@JohnnyMcWeed
Copy link
Contributor

What steps will reproduce the problem?

Use theme/create command

What is the expected result?

Output files should work as theme by default.

What do you get instead?

Not working files.

Additional infos

  • Wrong asset css source
  • Wrong namespace in Asset
  • Asset needs $sourcePath set I think
@nadar
Copy link
Member

nadar commented May 5, 2020

Do you get an exception? the luya\web\Asset does not require a sourcePath, it has a default path:

https://luya.io/api/luya-web-Asset

@JohnnyMcWeed
Copy link
Contributor Author

JohnnyMcWeed commented May 6, 2020

  1. Wrong asset css source
core/console/commands/ThemeController.php
-> line 162
\'{$themeName}.css\',
  1. Wrong namespace in Asset
core/console/commands/ThemeController.php
-> line 180 
use luya\themes\frontend\\'.$className.';
  1. Asset needs $sourcePath set I think

Sorry my fault, bad explanation. Yes the asset is correct like this, but this seems somehow confusing that there's a need to add a new asset folder inside -> The file or directory to be published does not exist: F:\Projekte\projectname\themes\themename\resources\theme-asset (As the folder "theme-asset" is not built by default)

So I think either the $sourcePath should be set or the folder should be built automatically. So probably somehow here add the folder...

core/console/commands/ThemeController.php
-> line 75 
$folders = [

boehsermoe added a commit to boehsermoe/luya that referenced this issue Jul 2, 2020
boehsermoe added a commit to boehsermoe/luya that referenced this issue Jul 2, 2020
@boehsermoe
Copy link
Member

@JohnnyMcWeed thank you for reporting, I open a PR to fix it.

nadar added a commit that referenced this issue Jul 2, 2020
* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Documentation for block preview luyadev/luya-module-cms#83

* Revert PHP doc

* Travis mysql connection failed

* config with env scope

* used call_user_func for callback

* Update Config.php

* theme load without exception as default

* theme load without exception as default

* theme load without exception as default

* Update ThemeManager.php

* changelog #1969

* Update CHANGELOG.md

* add php doc

* theme management image for guide #1983

* Update app-themes.md

* Theme command

* Create theme command

* Changelog

* fixed theme/create command #2020

* Changelog #2020

* Fix unit test for theme create command

* Fix unit test for theme create command

Co-authored-by: Basil <git@nadar.io>
boehsermoe added a commit to boehsermoe/luya that referenced this issue Jul 6, 2020
boehsermoe added a commit to boehsermoe/luya that referenced this issue Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants