Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search group membership use uid instead of userDN in LDAP provider #8

Closed
Charles546 opened this issue Jul 25, 2018 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@Charles546
Copy link

This tool is almost like a Swiss army knife for authentication. I can put it in front of almost everything. Only problem is that the group in my ldap server use uid to list members instead of using DN. I can't find a way to make it work. I would really like to use uid attribute to lookup for the groups of a member.

@Luzifer Luzifer self-assigned this Jul 25, 2018
Luzifer added a commit that referenced this issue Jul 25, 2018
refs #8

Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer
Copy link
Owner

Luzifer commented Jul 25, 2018

This indeed isn't possible currently as I've never thought anyone would use the uid in a member or uniqueMember attribute in a group. (I've always seen DNs in those attributes…)

I've assembled a currently untested patch in #9 which should allow you to do this by changing the group query to (|(member={1})(uniqueMember={1})) in case you are using the uid as username_attribute. Please test if this works for you and I'm going to merge this in! 🙂

(If you are not fluent with building Go projects I can provide a binary or Docker container for your test, just tell me what you need to test the change.)

@Luzifer Luzifer added the enhancement New feature or request label Jul 25, 2018
@Luzifer
Copy link
Owner

Luzifer commented Jul 26, 2018

Closed by #9, included in v0.8.0 release

@Luzifer Luzifer closed this as completed Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants