Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue that allowed API to unmute a video when App had it muted #221

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

lvcabral
Copy link
Owner

There are two levels of control of the audio output, one in the API and other in the App.
This PR fixed inconsistencies on the state machine of these flags, also rename test/emulator folder to test/simulator and improved the videotest.brs e2e test.

Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lvcabral lvcabral merged commit 7808957 into master Jan 19, 2024
3 checks passed
@lvcabral lvcabral deleted the fix-mute-api-vs-app branch January 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant