feat: adding support for teams under label approvers #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altJake
force-pushed
the
feat/allow-team-usage
branch
2 times, most recently
from
d04bc5a
to
2a41138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In bigger organizations or team structures, it is harder to maintain the lists expected in the
team-approvers.ymlconfiguration file. For example if there are many individuals, individuals moving around or many join/leave often.Often times, maintaining such organizational structures are done via organization teams that encapsulate that manual work. However the current implementation expects a list of individual user handlers.
Solution
Adding support for team handlers, as well as flattening them and remove duplicates when assigning / expecting approvals for a specific label
closes #5