Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket.Net changes default JSON serialization settings #31

Open
jhonny-apiiro opened this issue Feb 14, 2024 · 0 comments
Open

Bitbucket.Net changes default JSON serialization settings #31

jhonny-apiiro opened this issue Feb 14, 2024 · 0 comments

Comments

@jhonny-apiiro
Copy link

jhonny-apiiro commented Feb 14, 2024

this static ctor changes the default JSON serialization settings in the application.
I think this is a problem, since other code may rely on the "default" set of defaults.
I don't expect a library to change the global settings in my application..

For example, in the application I'm working on now, we have many integrations with many 3rd party APIs.
I spent more time than I would've liked trying to figure out why an integration with service X was working as expected normally, but not working only on certain servers / certain customers.
turns out that, as long as the bitbucket integration wasn't turned on, everything was great. but once we turned on integration for bitbucket AND service X, service X stopped working as expected.
that's because Bitbucket.NET changed how the requests to service X were serialized!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant