Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable E501 - line too long lint #190

Open
adamsardar opened this issue Mar 4, 2024 · 0 comments
Open

Enable E501 - line too long lint #190

adamsardar opened this issue Mar 4, 2024 · 0 comments
Labels
CI improvements to continuous integration good first issue Good for newcomers

Comments

@adamsardar
Copy link
Contributor

What

Remove any mentions of ignoring E501 from the ruff configuration so that line length is controlled once again, in the same that black once did (ideally set to 88 to maintain the standard).

Why

Overlong lines can hurt readability. PEP 8, for example, recommends limiting lines to 79 characters. See the ruff documentation for the rule.

How

As mentioned in #169, where E501 support was attempted:

E501 line length - apparently 88 is the line length preferred by black but with this set it was suggesting editing a lot of lines in supposedly black approved code

The task of this ticket is to figure out what is going wrong (if anything) and bring the codebase back into support with E501 enabled.

@adamsardar adamsardar added the good first issue Good for newcomers label Mar 4, 2024
@davidhopkinson26 davidhopkinson26 added the CI improvements to continuous integration label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI improvements to continuous integration good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants