More comprehensive CI process #187
Conversation
…otebooks are lintable)
… ruff tool control to be via package metadata
…f available pythons
➕ md and emoji deps for smart pytest results
…arn 1.2 (with no backwards compatibility from 1.4). See #184
…tion not behaviour - see #155.
…ut for the way that we have tests setup. Plus it adds TWO dependencies.
| @@ -549,7 +549,7 @@ def __init__( | |||
| weights_column: str | None = None, | |||
| prior: int = 0, | |||
| level: str | list | None = None, | |||
| unseen_level_handling: str | int | float | None = None, | |||
| unseen_level_handling: str | float | None = None, | |||
There was a problem hiding this comment.
N - is this just because int is redundant or is this a fix for something?
There was a problem hiding this comment.
It's redundant.
From PEP 484:
Rather than requiring that users write import numbers and then use numbers.Float etc., this PEP proposes a straightforward shortcut that is almost as effective: when an argument is annotated as having type float, an argument of type int is acceptable; similar, for an argument annotated as having type complex, arguments of type float or int are acceptable.
Good chat in this thread.
There was a problem hiding this comment.
Whilst this PR has been approved - I'll just wait a day or so to check that something unexpected has happened here. We aren't in a rush.
There was a problem hiding this comment.
I had a double check of the code path and am confident that we'll be ok. I'll merge this in.
maincan still be passing with the above new functionality. This isn't ideal, as typically the bug below would have been fixed on a different branch. Reality of changing CI I feel, but if the reviewer would prefer a separate PR we can do that.sparseargument forsklearn.OneHotEncoderis deprecated so we now usesparse_output. Closes [Bug]: OneHotEncodingTransformer no long compatible with sklearn #186 and [Bug]: Tests fail in Py > 3.8 #184sklearn1.4+, which is the most recent wheel available for py39+)sklearnversion to1.2.0.main. Developers can receive feedback on their contributions before PR stage.uvto install dependencies. The 'Install Dependencies' stage has gone from 20 seconds to 4 seconds.ruffto more up-to-date version, unlocking the formatter options to replaceblack.ruff autofixes.lint.preview = true(see docs), but just added E501 to ignore, so that's still there for Feature/update pre commit #169 to tackle.ubuntu-22.04.Closes #179.