Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comply to ruff flake8_bubbear #131

Merged
merged 6 commits into from
Aug 14, 2023
Merged

comply to ruff flake8_bubbear #131

merged 6 commits into from
Aug 14, 2023

Conversation

ClaireF57
Copy link
Contributor

@ClaireF57 ClaireF57 commented Jul 25, 2023 •
edited

Update code to comply to ruff - flake8_bugbear :
Errors to fix related to :

  • B028 Stacklevel in warnings
  • B006 mutable argument
  • B904 raise and from
  • B023 function loop

@ClaireF57
Copy link
Contributor Author

Draft PR to address issue 112 .
cc @davidhopkinson26 , @Sarah-TaylorKnight

@ClaireF57 ClaireF57 changed the title comply to ruff B028_stacklevel comply to ruff flake8_bubbear Jul 25, 2023
@ClaireF57 ClaireF57 marked this pull request as ready for review July 26, 2023 14:06
davidhopkinson26
davidhopkinson26 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I updated the changelog.

@davidhopkinson26 davidhopkinson26 merged commit 41e99fa into lvgig:develop Aug 14, 2023
1 check passed
@davidhopkinson26 davidhopkinson26 mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClaireF57 @davidhopkinson26