Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Lack of a user defined margin #8

Open
michaesc opened this issue Jul 7, 2021 · 2 comments
Open

Lack of a user defined margin #8

michaesc opened this issue Jul 7, 2021 · 2 comments

Comments

@michaesc
Copy link

michaesc commented Jul 7, 2021

Lack of a user defined colour pad

This bug report refers to the lack of a user defined colour pad, the empty area around a QR code.

Colour padding

Machine reading improves when codes have a large padded area around them, in the same colour as the very thin margin as defined in existing sources.

int margin = (obj_w - scaled) / 2;

Suggestion

To introduce a user defined padded area, a parameter could be added wherever graphic size is referenced (in buffers, allocation, and construction.)

Pull request pending

I've solved this problem and will submit a pull request called Colourpad Addition 1A.

michaesc pushed a commit to michaesc/lv_lib_qrcode that referenced this issue Jul 7, 2021
@michaesc
Copy link
Author

michaesc commented Jul 7, 2021

Close this if pull request #9 is merged, thanks.

Or just close it regardless, if you think the problem does not exist. No offense taken if you do that.

@kisvegabor
Copy link
Member

Thanks, I commented on the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants