-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lv_examples: Add Kconfig file for menuconfig interface and add demo widgets configuration in it. #184
Conversation
…idgets configuration in it.
I rarely use menuconfig so can't really decide if it's a good practice or not. I suppose selecting the default demo still makes possible to add demo/code by hand. If so I think it won't harm anything besides the extra maintenance. |
I agree with @kisvegabor. |
Sorry; I hit the close button by accident. Reopened. |
I agree, I thought this repo is to showcase LVGL in esp32, maybe not to be used as a project template, that's what the separated components are being created for, the user would include which they need. I will try to add the examples later this week, let's see how that plays out. |
…nuconfig interface
Current What do you think? |
Only the DEMOs can be enabled/disabled from the config. E.g. lv_ex_style_1 has no |
There's only two options on the |
@kisvegabor I've removed the style examples from the menuconfig interface. It does look like this now: |
In lv_ex_conf_templ.h there are some more options. I think it works well if you select a demo to rum, it will enable it the demo itself as well. |
The config file you point out is newer, I would need to update Can we merge this as first implementation and then update both |
I meant e.g. for |
Because the So I wanted to merge this, do a release of the repo, and then update both |
Alright! |
Ok, I will merge this and another PR (#195), then do a release and then update both lvgl and lv_examples. Then update both config files and Kconfig files, if everything is working we could then consider adding the Kconfig file to the main repos. |
@kisvegabor is right, will open a new PR about this once |
Here´s the menuconfig interface so far, I'm thinking on letting the user choose which demo or example to run, what do you think?