Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lv_examples: Add Kconfig file for menuconfig interface and add demo widgets configuration in it. #184

Closed
wants to merge 3 commits into from

Conversation

C47D
Copy link
Collaborator

@C47D C47D commented Aug 18, 2020

Here´s the menuconfig interface so far, I'm thinking on letting the user choose which demo or example to run, what do you think?

imagen

@kisvegabor
Copy link
Member

I rarely use menuconfig so can't really decide if it's a good practice or not. ☹️

I suppose selecting the default demo still makes possible to add demo/code by hand. If so I think it won't harm anything besides the extra maintenance.

@embeddedt
Copy link
Member

I agree with @kisvegabor.

@embeddedt embeddedt closed this Aug 18, 2020
@embeddedt embeddedt reopened this Aug 18, 2020
@embeddedt
Copy link
Member

embeddedt commented Aug 18, 2020

Sorry; I hit the close button by accident. Reopened.

@C47D
Copy link
Collaborator Author

C47D commented Aug 18, 2020

I agree, I thought this repo is to showcase LVGL in esp32, maybe not to be used as a project template, that's what the separated components are being created for, the user would include which they need. I will try to add the examples later this week, let's see how that plays out.

@C47D
Copy link
Collaborator Author

C47D commented Aug 28, 2020

@embeddedt @kisvegabor

Current lv_examples menuconfig (not definitive), missing: widget and get started examples. It need some cosmetic changes, I don't personally like having all the available options always enabled. Will work on it this weekend.

imagen

What do you think?

@kisvegabor
Copy link
Member

@C47D

Only the DEMOs can be enabled/disabled from the config. E.g. lv_ex_style_1 has no define guards. It's because these examples are usually short and small so I think it's not worth the effort to enable/disable them one by one. So I think it's enough to have options already present in lv_ex_conf.h

@C47D
Copy link
Collaborator Author

C47D commented Aug 28, 2020

There's only two options on the lv_ex_config file, I will check it again tho.

@C47D
Copy link
Collaborator Author

C47D commented Aug 29, 2020

@kisvegabor I've removed the style examples from the menuconfig interface. It does look like this now:

imagen

@kisvegabor
Copy link
Member

In lv_ex_conf_templ.h there are some more options.

I think it works well if you select a demo to rum, it will enable it the demo itself as well.
Do you plan to make examples selectable as well? I mean not to enable e.g. lv_ex_btn_1() just select it to run automatically.

@C47D
Copy link
Collaborator Author

C47D commented Sep 1, 2020

The config file you point out is newer, I would need to update lv_examples.

Can we merge this as first implementation and then update both lv_examples and lvgl. What do you think?

@kisvegabor
Copy link
Member

I meant e.g. for LV_EXAMPLES_DEMO_BENCHMARK you don't enable LV_DEMO_BENCHMARK in lv_ex_conf.h.

@C47D
Copy link
Collaborator Author

C47D commented Sep 1, 2020

Because the lv_ex_config file doesn't have that option because it's old, we would need to update lv_examples to have it.

So I wanted to merge this, do a release of the repo, and then update both lv_examples and lvgl.

@kisvegabor
Copy link
Member

So I wanted to merge this, do a release of the repo, and then update both lv_examples and lvgl.

Alright!

@C47D
Copy link
Collaborator Author

C47D commented Sep 2, 2020

Ok, I will merge this and another PR (#195), then do a release and then update both lvgl and lv_examples. Then update both config files and Kconfig files, if everything is working we could then consider adding the Kconfig file to the main repos.

@C47D C47D marked this pull request as ready for review September 2, 2020 14:09
@C47D
Copy link
Collaborator Author

C47D commented Sep 3, 2020

@kisvegabor is right, will open a new PR about this once lv_examples gets updated. Closing this.

@C47D C47D closed this Sep 3, 2020
@C47D C47D deleted the lv_example_menuconfig branch September 3, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants