Skip to content

Commit 9b09182

Browse files
committed
fix(thorvg): link lvgl_thorvgl with lvgl
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
1 parent c81f654 commit 9b09182

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

env_support/cmake/custom.cmake

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,7 @@ if(NOT LV_CONF_BUILD_DISABLE_THORVG_INTERNAL)
4848
add_library(lvgl_thorvg ${THORVG_SOURCES})
4949
add_library(lvgl::thorvg ALIAS lvgl_thorvg)
5050
target_include_directories(lvgl_thorvg SYSTEM PUBLIC ${LVGL_ROOT_DIR}/src/libs/thorvg)
51-
if(LV_CONF_PATH)
52-
target_compile_definitions(lvgl_thorvg PUBLIC LV_CONF_PATH=${LV_CONF_PATH})
53-
endif()
54-
if(LV_CONF_SKIP)
55-
target_compile_definitions(lvgl_thorvg PUBLIC LV_CONF_SKIP=1)
56-
endif()
51+
target_link_libraries(lvgl_thorvg PUBLIC lvgl)
5752
endif()
5853

5954
# Build LVGL example library
@@ -146,7 +141,7 @@ if(NOT LV_CONF_BUILD_DISABLE_THORVG_INTERNAL)
146141
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
147142
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin"
148143
PUBLIC_HEADER "${LVGL_PUBLIC_HEADERS}")
149-
144+
150145
install(
151146
TARGETS lvgl_thorvg
152147
ARCHIVE DESTINATION "${LIB_INSTALL_DIR}"
@@ -164,7 +159,7 @@ if(NOT LV_CONF_BUILD_DISABLE_DEMOS)
164159
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
165160
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin"
166161
PUBLIC_HEADER "${LVGL_PUBLIC_HEADERS}")
167-
162+
168163
install(
169164
TARGETS lvgl_demos
170165
ARCHIVE DESTINATION "${LIB_INSTALL_DIR}"
@@ -182,7 +177,7 @@ if(NOT LV_CONF_BUILD_DISABLE_EXAMPLES)
182177
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
183178
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin"
184179
PUBLIC_HEADER "${LVGL_PUBLIC_HEADERS}")
185-
180+
186181
install(
187182
TARGETS lvgl_examples
188183
ARCHIVE DESTINATION "${LIB_INSTALL_DIR}"

tests/CMakeLists.txt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,12 @@ set(COMPILE_OPTIONS
162162
${BUILD_TARGET_DEF}
163163
)
164164

165-
filter_compiler_options(C LVGL_COMPILE_OPTIONS ${COMPILE_OPTIONS})
165+
filter_compiler_options(C LVGL_C_COMPILE_OPTIONS ${COMPILE_OPTIONS})
166166

167167
# Options test cases are compiled with.
168-
filter_compiler_options(C LVGL_TESTFILE_COMPILE_OPTIONS ${LVGL_COMPILE_OPTIONS} -Wno-missing-prototypes)
168+
filter_compiler_options(C LVGL_TESTFILE_COMPILE_OPTIONS ${LVGL_C_COMPILE_OPTIONS} -Wno-missing-prototypes)
169169

170-
filter_compiler_options(CXX LVGL_THORVG_COMPILE_OPTIONS
170+
filter_compiler_options(CXX LVGL_CXX_COMPILE_OPTIONS
171171
${COMPILE_OPTIONS}
172172
-Wno-shadow
173173
-Wno-unused-parameter
@@ -182,10 +182,11 @@ get_filename_component(LVGL_DIR ${LVGL_TEST_DIR} DIRECTORY)
182182

183183
# Include lvgl project file.
184184
include(${LVGL_DIR}/CMakeLists.txt)
185-
target_compile_options(lvgl PUBLIC ${LVGL_COMPILE_OPTIONS})
186-
target_compile_options(lvgl_thorvg PUBLIC ${LVGL_THORVG_COMPILE_OPTIONS})
185+
target_compile_options(lvgl PUBLIC $<$<COMPILE_LANGUAGE:C>: ${LVGL_C_COMPILE_OPTIONS}>)
186+
target_compile_options(lvgl PUBLIC $<$<COMPILE_LANGUAGE:ASM>: ${LVGL_C_COMPILE_OPTIONS}>)
187+
target_compile_options(lvgl PUBLIC $<$<COMPILE_LANGUAGE:CXX>: ${LVGL_CXX_COMPILE_OPTIONS}>)
187188
if (TARGET lvgl_examples)
188-
target_compile_options(lvgl_examples PUBLIC ${LVGL_COMPILE_OPTIONS})
189+
target_compile_options(lvgl_examples PUBLIC ${LVGL_C_COMPILE_OPTIONS})
189190
endif()
190191

191192

0 commit comments

Comments
 (0)