-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(anim_timeline) avoid calling lv_anim_del(NULL, NULL) #2628
Conversation
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
…_timeline_set_progress() adds user_data, act_time uses int32_t type
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
… update lv_anim_timeline_1.c example Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
…o FASTSHIFT-anim-timeline
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: _VIFEXTech <1290176185@qq.com>
c5ec77e
to
276ba97
Compare
f06d533
to
52f19a1
Compare
So far I thought that an animation doesn't make much sens if neither An other solution could be to add a dummy callback to BTW, won't the current solution (in this PR) cause memory leak? |
Why is there a memory leak, is it |
Because if both |
|
But if an animation is not deleted in |
You are right. I thought of a solution: When it is detected that |
Looks good, thank you! |
Description of the feature or fix
This PR is about the resolution of #2589.
Avoid calling lv_anim_del(NULL, NULL) to cause all animations to be deleted.
Checkpoints