Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor fs issue #2682

Merged
merged 5 commits into from Oct 18, 2021
Merged

Fix minor fs issue #2682

merged 5 commits into from Oct 18, 2021

Conversation

xiaoxiang781216
Copy link
Collaborator

@xiaoxiang781216 xiaoxiang781216 commented Oct 17, 2021 •
edited

Description of the feature or fix

  • fix(fs): replace all tab to space and other minor style fix
  • fix(extra/fs): rename lv_fs_libs.h to lv_fsdrv.h
  • fix(extra/fs/stdio): fix the wrong directory path in fs_dir_open
  • fix(extra/fs/posix): implement in fs_dir_read
  • fix(extra/fs/posix): return file handle directly to avoid malloc

Checkpoints

@xiaoxiang781216
fix(fs): replace all tab to space and other minor style fix
44e052a 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
fix(extra/fs): rename lv_fs_libs.h to lv_fsdrv.h
f553dd6 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
fix(extra/fs/stdio): fix the wrong directory path in fs_dir_open
9812c6e 
and remove the duplicated or platform specific code

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
fix(extra/fs/posix): implement in fs_dir_read
2ff82cf 
and fix the wrong directory path in fs_dir_open

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
fix(extra/fs/posix): return file handle directly to avoid malloc
327135e 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 changed the title extra(fs): rename lv_fs_libs.h to lv_fsdrv.h Fix minor fs issue Oct 17, 2021
@kisvegabor
Copy link
Member

I like the lv_fsdrv and the idea of return the file descriptor directly from posix open.

Thanks.

@kisvegabor kisvegabor merged commit 608d06e into lvgl:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiaoxiang781216 @kisvegabor