Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gpu-arm2d): fix a blending issue in blend-normal-with-mask-and-opa #5163

Merged
merged 2 commits into from Jan 3, 2024
Merged

fix(gpu-arm2d): fix a blending issue in blend-normal-with-mask-and-opa #5163

merged 2 commits into from Jan 3, 2024

Conversation

GorgonMeducer
Copy link
Contributor

@GorgonMeducer GorgonMeducer commented Jan 3, 2024

Help us review this PR! Anyone can approve it or request changes.

Description of the feature or fix

The open-source community reported a blend issue of GPU-Arm2D found in LVGL8.3.11.
For blend-normal-with-mask-and-opa, the opa has no effects due to using the wrong API of arm-2d.

Checkpoints

Copy link
Contributor

@C47D C47D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Off topic : could a test catch this issue?

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just out of curiosity: where was it reported?

@kisvegabor
Copy link
Member

kisvegabor commented Jan 3, 2024

Off topic : could a test catch this issue?

@GorgonMeducer Does Arm2D have a desktop compatible version that we can use in our tests?

@kisvegabor kisvegabor merged commit f2c1032 into lvgl:release/v8.3 Jan 3, 2024
17 checks passed
@GorgonMeducer
Copy link
Contributor Author

GorgonMeducer commented Jan 4, 2024

@kisvegabor YES. Arm-2D is compatible with x86. We even have a VSCode+Make+SDL project:

Please check this:
https://github.com/GorgonMeducer/NotGenshinClock/tree/Demo-for-Events-2023

For use with LVGL, you only need the folder Arm-2D/Library, not anything else.

@GorgonMeducer GorgonMeducer deleted the fix-gpu-arm-2d branch January 4, 2024 03:14
@kisvegabor
Copy link
Member

That's great! Have you already tried the lv_demo_render with on PC with Arm2D? Here are the tests for SW render.

@GorgonMeducer
Copy link
Contributor Author

@kisvegabor NOT yet. Would try it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants