fix(vector) : add path bounding and matrix transform functions. #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2024 10:04
Signed-off-by: zhangjipeng <zhangjipeng@xiaomi.com>
Signed-off-by: zhangjipeng <zhangjipeng@xiaomi.com>
Signed-off-by: zhangjipeng <zhangjipeng@xiaomi.com>
XuNeo
reviewed
Jan 19, 2024
src/draw/lv_draw_vector.c
Outdated
Comment on lines
324
to
325
| for(uint32_t i = 1; i < len; i++) { | ||
| lv_fpoint_t * p = lv_array_at(&path->points, i); |
There was a problem hiding this comment.
Instead of calling lv_arraya_at in the loop, which will always do sanity check, we can do this way since it's an actual array.
lv_fpoint_t * p = lv_array_at(&path->points, 0);
for(uint32_t i = 1; i < len; i++) {
p[i].x = We can add a helper similar to STL vector to get the first element.
lv_array_front(&array);
kisvegabor
reviewed
Jan 19, 2024
| @@ -195,6 +195,23 @@ void lv_matrix_multiply(lv_matrix_t * matrix, const lv_matrix_t * m) | |||
| _multiply_matrix(matrix, m); | |||
| } | |||
|
|
|||
| void lv_matrix_transform_point(const lv_matrix_t * matrix, lv_fpoint_t * point) | |||
There was a problem hiding this comment.
Suggested change
| void lv_matrix_transform_point(const lv_matrix_t * matrix, lv_fpoint_t * point) | |
| void lv_point_transform_by_matrix(lv_fpoint_t * point, const lv_matrix_t * matrix) |
There was a problem hiding this comment.
I think it's weird that there is a single function called 'lv_point_xxxx' here.
There was a problem hiding this comment.
I think it classified as a method of matrix， how about that？
There was a problem hiding this comment.
Okay, let's keep it as it is.
| point->y = x * matrix->m[0][1] + y * matrix->m[1][1] + matrix->m[1][2]; | ||
| } | ||
|
|
||
| void lv_matrix_transform_path(const lv_matrix_t * matrix, lv_vector_path_t * path) |
There was a problem hiding this comment.
Suggested change
| void lv_matrix_transform_path(const lv_matrix_t * matrix, lv_vector_path_t * path) | |
| void lv_path_transform_by_matrix(lv_vector_path_t * path, const lv_matrix_t * matrix) |
Signed-off-by: zhangjipeng <zhangjipeng@xiaomi.com>
|
Will we add tests for this? |
W-Mai
approved these changes
Jan 19, 2024
Some tests would be really great! |
Signed-off-by: zhangjipeng <zhangjipeng@xiaomi.com>
kisvegabor
approved these changes
Jan 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help us review this PR! Anyone can approve it or request changes.
Description of the feature or fix
A clear and concise description of what the bug or new feature is.
Checkpoints
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions