Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fbdev): Allow forcing refresh #5444

Merged
merged 1 commit into from Jan 24, 2024

Conversation

Johennes
Copy link
Contributor

Description of the feature or fix

A clear and concise description of what the bug or new feature is. This feature exists in the old fbdev driver in lv_drivers.

Notes

@kisvegabor
Copy link
Member

What the problem does it resolves? Tearing?

@Johennes
Copy link
Contributor Author

Sorry, I was mistaken. This didn't exist in lv_drivers upstream. We had only made the change on our fork. The issue that spawned this is https://gitlab.com/cherrypicker/unl0kr/-/issues/34. On some devices the screen would stay black or only render the area that had changed. The problem doesn't occur anymore when using direct rendering together with the force refresh feature from this PR.

@kisvegabor
Copy link
Member

I see, thank you! Would it make sense to enable it by default?

@Johennes
Copy link
Contributor Author

No, I wouldn't recommend that actually. When I enable this on my laptop, it's causing a noticeable performance impact. It's not negatively noticeable on the device affected by the issue. But I'd definitely only turn it on when needed. In our app we've just made it a config setting.

@kisvegabor
Copy link
Member

All clear, thank you. Final question: would you be interested in adding docs for the frame buffer device driver? Similar to this.

@Johennes
Copy link
Contributor Author

Good idea. I've added some rudimentary docs.

@kisvegabor
Copy link
Member

It was quick! Thank you! 🙂

@kisvegabor kisvegabor enabled auto-merge (squash) January 24, 2024 13:38
@kisvegabor kisvegabor merged commit 03cf1d1 into lvgl:master Jan 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants