Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cache): only cache header info for file type of image #5455

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

XuNeo
Copy link
Collaborator

@XuNeo XuNeo commented Jan 24, 2024

Description of the feature or fix

For variable type of image, the header cache won't be that useful considering that PNG, JPG are easy to get info.
Furthermore, if the image has changed, which is usual for variable type of image in RAM, user must manually invalidate the cache.

So it's better to only add header to cache for file type of image.

cc @W-Mai

Notes

Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
@kisvegabor kisvegabor merged commit cfb49e9 into lvgl:master Jan 24, 2024
16 checks passed
@XuNeo XuNeo deleted the header-cache-for-file-only branch January 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants