Removed LV_ATTRIBUTE_FAST_MEM function attribute from prototypes and kept only on function declarations or static inline functions #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kept only on function declarations or static inline functions
kisvegabor
approved these changes
Jan 25, 2024
|
Awesome, thank you! How much performance improvement do you see when |
I have not measured it. Will get back when I have some numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Removed LV_ATTRIBUTE_FAST_MEM function attribute from prototypes and kept only on function declarations and static inline functions.
This fixes an issue in ESP-IDF where section attributes use COUNTER macro, and this results in prototype and declaration having different sections assigned
This was previously fixed in the 8.x release.
See #4391 and #4404