Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_decoder): add stride warning #5471

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

FASTSHIFT
Copy link
Collaborator

@FASTSHIFT FASTSHIFT commented Jan 25, 2024

Description of the feature or fix

Using width to calculate stride will lead to very difficult consistency problems.
We should remind users to set the correct stride information in the decoder.

Notes

Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
@FASTSHIFT FASTSHIFT requested a review from XuNeo January 25, 2024 04:03
XuNeo
XuNeo previously approved these changes Jan 25, 2024
@FASTSHIFT
Copy link
Collaborator Author

We need to update all image resources inside lvgl, otherwise a large number of warning logs will be generated.

@kisvegabor
Copy link
Member

For the current demos I suggest adding the stride by hand. It might be complicated to generate the images automatically due to special cases like

  • Set special color format
  • We might want to convert one image assets in multiple formats.

@kisvegabor
Copy link
Member

We need to update all image resources inside lvgl, otherwise a large number of warning logs will be generated.

Due to this IMO we shall update the strides in the PR too.

PGNetHun
PGNetHun previously approved these changes Jan 29, 2024
@kisvegabor
Copy link
Member

What about this?

We need to update all image resources inside lvgl, otherwise a large number of warning logs will be generated.

@FASTSHIFT
Copy link
Collaborator Author

What about this?

We need to update all image resources inside lvgl, otherwise a large number of warning logs will be generated.

I used a script to automate the resource changes: #5653

@FASTSHIFT FASTSHIFT dismissed stale reviews from PGNetHun and XuNeo via bd7814b February 15, 2024 04:51
@FASTSHIFT
Copy link
Collaborator Author

Considering that the decoder has not been fully adapted, first reduce the LOG output level.

@FASTSHIFT FASTSHIFT merged commit baf7fed into lvgl:master Feb 15, 2024
16 checks passed
@FASTSHIFT FASTSHIFT deleted the feat_stride_warn branch February 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants