refactor(snapshot): use draw buffer interface #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lv_snapshot_take_to_buf` should use lv_draw_buf_t instead of assembling the struct manually. Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
XuNeo
requested review from
FASTSHIFT and
kisvegabor
and removed request for
FASTSHIFT
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
W-Mai
suggested changes
Jan 26, 2024
Co-authored-by: Benign X <1341398182@qq.com>
XuNeo
commented
Jan 26, 2024
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
FASTSHIFT
reviewed
Jan 29, 2024
kisvegabor
reviewed
Jan 29, 2024
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
kisvegabor
approved these changes
Jan 30, 2024
|
Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
lv_snapshot_take_to_bufshould use lv_draw_buf_t instead of assembling the struct manually.Fix #5261
The issue exposed in #5483 suggests that we should avoid converting between
lv_image_dsc_tandlv_draw_buf_t.The rule is that
lv_image_dsc_tis for constant C-array image assets. Andlv_draw_buf_tis for image used in run-time._lv_snapshot_take_to_bufandlv_snapshot_freefor legacy use.Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions