Repository navigation
chore(indev): Cleanup before working in double and triple click support - #5512
Merged
Merged
Conversation
Use is_enabled instead, this removed a bunch of boolean negations.
Contributor
Author
|
What is the policy of introducing new enums instead of magic numbers? I was planning to replace the magic values assigned to this flags of uint8_t long_pr_sent : 1;
uint8_t reset_query : 1;
uint8_t disabled : 1;
uint8_t wait_until_release : 1; |
PGNetHun
approved these changes
Jan 28, 2024
FASTSHIFT
approved these changes
Jan 29, 2024
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Use is_enabled instead, this removed a bunch of boolean negations. Found while studying indev for double and tiple click support.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions