Skip to content

chore(indev): Cleanup before working in double and triple click support - #5512

Merged
FASTSHIFT merged 1 commit into
lvgl:masterfrom
C47D:chore_indev
Jan 29, 2024
Merged

FASTSHIFT merged 1 commit into
lvgl:masterfrom
C47D:chore_indev

Conversation

@C47D

@C47D C47D commented Jan 27, 2024

Copy link
Copy Markdown
Contributor

Description of the feature or fix

Use is_enabled instead, this removed a bunch of boolean negations. Found while studying indev for double and tiple click support.

Notes

Use is_enabled instead, this removed a bunch of boolean negations.
@C47D

C47D commented Jan 27, 2024 •

Copy link
Copy Markdown
Contributor Author

What is the policy of introducing new enums instead of magic numbers? I was planning to replace the magic values assigned to this flags of _lv_indev_t with enums.

uint8_t long_pr_sent : 1;
uint8_t reset_query : 1;
uint8_t disabled : 1;
uint8_t wait_until_release : 1;

@C47D C47D changed the title chore(indev): Replace is_disabled checks chore(indev): Cleanup before working in double and tiple click support Jan 27, 2024
@C47D C47D changed the title chore(indev): Cleanup before working in double and tiple click support chore(indev): Cleanup before working in double and triple click support Jan 27, 2024

@W-Mai W-Mai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FASTSHIFT
FASTSHIFT merged commit 26e29c1 into lvgl:master Jan 29, 2024
@C47D
C47D deleted the chore_indev branch January 29, 2024 14:55
HongChao6 pushed a commit to HongChao6/lvgl that referenced this pull request Oct 18, 2024
HongChao6 pushed a commit to HongChao6/lvgl that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants