Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(thorvg): fix warning #5535

Merged
merged 1 commit into from Jan 31, 2024
Merged

chore(thorvg): fix warning #5535

merged 1 commit into from Jan 31, 2024

Conversation

FASTSHIFT
Copy link
Collaborator

Description of the feature or fix

CC:  In file included from lvgl/lvgl/src/draw/sw/lv_draw_sw.c:22:
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:436:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
  436 | TVG_API Tvg_Canvas* tvg_swcanvas_create();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1040:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1040 | TVG_API Tvg_Paint* tvg_shape_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1715:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1715 | TVG_API Tvg_Gradient* tvg_linear_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1737:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1737 | TVG_API Tvg_Gradient* tvg_radial_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1959:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1959 | TVG_API Tvg_Paint* tvg_picture_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2066:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2066 | TVG_API Tvg_Paint* tvg_scene_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2144:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2144 | TVG_API Tvg_Saver* tvg_saver_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2226:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2226 | TVG_API Tvg_Animation* tvg_animation_new();
      | ^~~~~~~
CC:  lvgl/lvgl/src/draw/vg_lite/lv_draw_vg_lite_arc.c In file included from lvgl/lvgl/src/draw/sw/lv_draw_sw_vector.c:15:
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:436:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
  436 | TVG_API Tvg_Canvas* tvg_swcanvas_create();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1040:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1040 | TVG_API Tvg_Paint* tvg_shape_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1715:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1715 | TVG_API Tvg_Gradient* tvg_linear_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1737:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1737 | TVG_API Tvg_Gradient* tvg_radial_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1959:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1959 | TVG_API Tvg_Paint* tvg_picture_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2066:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2066 | TVG_API Tvg_Paint* tvg_scene_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2144:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2144 | TVG_API Tvg_Saver* tvg_saver_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2226:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2226 | TVG_API Tvg_Animation* tvg_animation_new();
      | ^~~~~~~

Notes

```bash
CC:  In file included from lvgl/lvgl/src/draw/sw/lv_draw_sw.c:22:
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:436:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
  436 | TVG_API Tvg_Canvas* tvg_swcanvas_create();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1040:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1040 | TVG_API Tvg_Paint* tvg_shape_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1715:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1715 | TVG_API Tvg_Gradient* tvg_linear_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1737:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1737 | TVG_API Tvg_Gradient* tvg_radial_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1959:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1959 | TVG_API Tvg_Paint* tvg_picture_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2066:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2066 | TVG_API Tvg_Paint* tvg_scene_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2144:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2144 | TVG_API Tvg_Saver* tvg_saver_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2226:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2226 | TVG_API Tvg_Animation* tvg_animation_new();
      | ^~~~~~~
CC:  lvgl/lvgl/src/draw/vg_lite/lv_draw_vg_lite_arc.c In file included from lvgl/lvgl/src/draw/sw/lv_draw_sw_vector.c:15:
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:436:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
  436 | TVG_API Tvg_Canvas* tvg_swcanvas_create();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1040:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1040 | TVG_API Tvg_Paint* tvg_shape_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1715:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1715 | TVG_API Tvg_Gradient* tvg_linear_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1737:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1737 | TVG_API Tvg_Gradient* tvg_radial_gradient_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:1959:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 1959 | TVG_API Tvg_Paint* tvg_picture_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2066:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2066 | TVG_API Tvg_Paint* tvg_scene_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2144:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2144 | TVG_API Tvg_Saver* tvg_saver_new();
      | ^~~~~~~
lvgl/lvgl/src/draw/sw/../../libs/thorvg/thorvg_capi.h:2226:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 2226 | TVG_API Tvg_Animation* tvg_animation_new();
      | ^~~~~~~
```

Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
Copy link
Contributor

@C47D C47D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuNeo XuNeo merged commit 7a02d24 into lvgl:master Jan 31, 2024
16 checks passed
@FASTSHIFT FASTSHIFT deleted the chore_thorvg_warn branch January 31, 2024 06:51
@XuNeo XuNeo restored the chore_thorvg_warn branch February 2, 2024 06:03
@XuNeo XuNeo deleted the chore_thorvg_warn branch February 2, 2024 06:04
kisvegabor pushed a commit that referenced this pull request Feb 5, 2024
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants