Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image, layer): add bitmap mask feature #5545

Merged
merged 6 commits into from
Feb 10, 2024

Conversation

kisvegabor
Copy link
Member

Description of the feature or fix

Allow using an A8 bitmap mask for

  • the image widget
  • as a style property in which case a layer will be created and that layer will be masked

Current limitations

  • In SW render transformation and mask doesn't work together
  • In SW render only RGB565A8 and A8 images cannot be masked at this moment.
  • The mask is always center aligned on the image. Tiling and positioning can be added later.

Test and docs is still missing. First, I would like to verify if you agree with my approach on this feature.

cc @XuNeo

Notes

@XuNeo
Copy link
Collaborator

XuNeo commented Feb 1, 2024

Thank you Gabor. It looks good to me.
@bjsylvia @terry0012 @FASTSHIFT Please help to review the code.

docs/overview/style-props.md Outdated Show resolved Hide resolved
scripts/style_api_gen.py Outdated Show resolved Hide resolved
src/draw/sw/lv_draw_sw.c Outdated Show resolved Hide resolved
@PGNetHun PGNetHun self-requested a review February 6, 2024 10:58
PGNetHun
PGNetHun previously approved these changes Feb 6, 2024
PGNetHun
PGNetHun previously approved these changes Feb 8, 2024
docs/overview/layer.rst Outdated Show resolved Hide resolved
@kisvegabor
Copy link
Member Author

@XuNeo I merge it now, please open an issue if feel like something is missing.

@kisvegabor kisvegabor merged commit 10978c9 into lvgl:master Feb 10, 2024
16 checks passed
@kisvegabor kisvegabor deleted the feat/img-mask branch February 10, 2024 19:57
@kisvegabor kisvegabor mentioned this pull request Feb 13, 2024
@kisvegabor kisvegabor restored the feat/img-mask branch March 20, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants