docs(indev): Document the relation between LV_INDEV_MODE_EVENT and data->continue_reading #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta->continue_reading This relation was introduced but not documented in commit 1881ef2 ("feat(indev): in event-driven mode,needn't `continue_reading` (lvgl#5363)"). The alternative and simpler approach would be to respect data->continue_reading unconditionally. Input devices that don't want to trigger the looping logic should simply never set continue_reading then. The following commits could be reverted: - commit 7e15886 ("fix(sdl): fix keyboard handling (lvgl#5575)") - commit 1881ef2 ("feat(indev): in event-driven mode,needn't `continue_reading` (lvgl#5363)") Commit 7e15886 disproves that continue_reading wasn't needed in event-driven mode.
PGNetHun
approved these changes
Feb 4, 2024
W-Mai
approved these changes
Feb 4, 2024
kisvegabor
pushed a commit
that referenced
this pull request
Feb 5, 2024
…ta->continue_reading (#5586)
kisvegabor
pushed a commit
to kisvegabor/lvgl_upstream
that referenced
this pull request
Feb 5, 2024
…ta->continue_reading (lvgl#5586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relation was introduced but not documented in commit 1881ef2 ("feat(indev): in event-driven mode,needn't
continue_reading(#5363)").The alternative and simpler approach would be to respect data->continue_reading unconditionally. Input devices that don't want to trigger the looping logic should simply never set continue_reading then. The following commits could be reverted:
continue_reading(feat(indev): in event-driven mode,needn'tcontinue_reading#5363)")Commit 7e15886 disproves that continue_reading wasn't needed in event-driven mode.