Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vg_lite): use pointer to access matrix element #5591

Merged
merged 1 commit into from Feb 5, 2024

Conversation

XuNeo
Copy link
Collaborator

@XuNeo XuNeo commented Feb 5, 2024

Description of the feature or fix

Make the code shorter, refactor only.

Notes

Make the code shorter

Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
@FASTSHIFT
Copy link
Collaborator

This code copy is from the original driver and it is recommended to keep it as is.

@XuNeo
Copy link
Collaborator Author

XuNeo commented Feb 5, 2024

Those are utility functions and prefixed by lv_. Utilities like matrix reverse calculation could be imported to lvgl directly.

@FASTSHIFT
Copy link
Collaborator

FASTSHIFT commented Feb 5, 2024

This can continue to expand the lv_matrix in this PR: #4883

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring makes sense to me.

@XuNeo XuNeo merged commit 9778599 into lvgl:master Feb 5, 2024
16 checks passed
@XuNeo XuNeo deleted the chore-vg-lite-matrix branch February 5, 2024 15:03
kisvegabor pushed a commit that referenced this pull request Feb 5, 2024
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
kisvegabor pushed a commit to kisvegabor/lvgl_upstream that referenced this pull request Feb 5, 2024
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants