feat(cache): use unified cache entry free callback #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee'ed For YUV variable image, the memory is not allocated by lvgl and thus clear ALLOCATED bit to avoid it being detroyed after decoder closes. Do not add this kind of image to cache, since it's life is managed by user. Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
XuNeo
force-pushed
the
vg_lite-decoder-not-allocated
branch
from
55a6a95
to
27c11fb
Compare
Before this, the only exception is vg-lite decoder. It needs to check if the draw buffer should be free'd or not. Now it's unified. User could still set a custom callback to free cache data but all built-in decoders now have the unified callback. Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
XuNeo
force-pushed
the
vg_lite-decoder-not-allocated
branch
from
27c11fb
to
5421258
Compare
kisvegabor
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Before this, the only exception is vg-lite decoder. It needs to check if the draw buffer should be free'd or not. Now it's unified.
User could still set a custom callback to free cache data but all built-in decoders now have the unified callback.
For VG-Lite decoder, the memory of YUV variable image is not allocated by lvgl and thus clear ALLOCATED bit to avoid it being destroyed after decoder closes. And do not add this kind of image to cache, since its life is managed by user.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions