fix(vg_lite): fix linear image use after free #5618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
Signed-off-by: FASTSHIFT <vifextech@foxmail.com>
FASTSHIFT
force-pushed
the
fix_vg_lite_grad_use_after_free
branch
from
aaf3414 to
03e6d8e
Compare
XuNeo
reviewed
Feb 7, 2024
Collaborator
XuNeo
left a comment
XuNeo
left a comment
There was a problem hiding this comment.
Please fix the compile warning.
Collaborator
Author
Done |
XuNeo
approved these changes
Feb 7, 2024
lion2tomato
pushed a commit
to lion2tomato/lvgl
that referenced
this pull request
Mar 19, 2024
VELAPLATFO-22913 Change-Id: I5cf49b6378abcc3516bca1e4b1eb16f7918d94e7 Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Signed-off-by: FASTSHIFT <vifextech@foxmail.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Signed-off-by: FASTSHIFT <vifextech@foxmail.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Signed-off-by: FASTSHIFT <vifextech@foxmail.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
linear grad in vg-lite is simulated using image, which means that
vg_lite_clear_gradcannot be called immediately after callingvg_lite_draw_gradto free the image memory because the GPU may not have finished drawing.Therefore, I introduced cache for management. On the one hand, it can reduce the overhead of frequently creating grad image images, and on the other hand, it can solve the problem of using after free asynchronous rendering by using delayed release.
cc @W-Mai
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions