-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix(stdlib): fix issues when using LVGL TLSF memory pool to manage more than 4 GiB of memory #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FASTSHIFT
merged 1 commit into
lvgl:master
from
MouriNaruto:fix-memory-pool-64bit-issues
Feb 24, 2024
Merged
fix(stdlib): fix issues when using LVGL TLSF memory pool to manage more than 4 GiB of memory #5720
FASTSHIFT
merged 1 commit into
lvgl:master
from
MouriNaruto:fix-memory-pool-64bit-issues
Feb 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think there are some issues should be also fixed for LVGL. (Need some time to do.) Kenji Mouri |
2256b4c to
570696a
Compare
Contributor
Author
|
It looks like all CIs are passed. It should be continued. Kenji Mouri |
XuNeo
previously approved these changes
Feb 22, 2024
Contributor
Author
FASTSHIFT
requested changes
Feb 22, 2024
…re than 4 GiB of memory
570696a to
ed7d1ff
Compare
FASTSHIFT
approved these changes
Feb 22, 2024
kisvegabor
approved these changes
Feb 24, 2024
Member
kisvegabor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
…re than 4 GiB of memory (lvgl#5720)
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
…re than 4 GiB of memory (lvgl#5720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description of the feature or fix
People will know that I'm developing UEFI applications with LVGL in recent days after read #5391 (comment).
Because UEFI memory pool will cause many memory fragments. So, my project uses LVGL builtin TLSF memory pool to manage the memory. And I found if I use LVGL TLSF memory pool to manage more than 4 GiB of memory, I cannot get the correct result via lv_mem_monitor API.
I also found the original LVGL implementation have considered about the 64-bit environments and many lv_mem APIs use size_t to manage size. So, I think it should not break the ABI for 32-bit environments if we use size_t type instead of uint32_t type to fix the issue. (For 64-bit LVGL users needs to recompile. But I think most people don't use 64-bit LVGL instance in the current stage. It should be acceptable.)
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.Kenji Mouri