fix(freetpye): fix the problem of incomplete font drawing when setting with italic #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-Mai
commented
Mar 6, 2024
FASTSHIFT
requested changes
Mar 6, 2024
FASTSHIFT
previously approved these changes
Mar 6, 2024
FASTSHIFT
reviewed
Mar 6, 2024
src/libs/freetype/lv_freetype.c
Outdated
| @@ -250,6 +250,11 @@ void lv_freetype_italic_transform(FT_Face face) | |||
| FT_Set_Transform(face, &matrix, NULL); | |||
| } | |||
|
|
|||
| int32_t lv_freetype_italic_transform_on_pos(lv_point_t point) | |||
| { | |||
| return point.x + FT_F16DOT16_TO_INT(point.y * 0x5800); | |||
There was a problem hiding this comment.
This 0x5800 special value can be defined using a macro
FASTSHIFT
approved these changes
Mar 7, 2024
XuNeo
approved these changes
Mar 7, 2024
lion2tomato
pushed a commit
to lion2tomato/lvgl
that referenced
this pull request
Mar 19, 2024
…g with italic (lvgl#5807) VELAPLATFO-27766 Change-Id: I210db2eab18b4b1cf177c1e68cc2091885c1afc3 Signed-off-by: xinbingnan<xinbingnan@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Before:
After:
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.