fix(fsdrv/fatfs): fix does not detect the end of entries in fs_dir_read #5826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fs_dir_read function not takes into account the end of the entries, since it never finishes reading the next one, thus entering a loop.
typo fix
C47D
approved these changes
Mar 11, 2024
FASTSHIFT
changed the title
FASTSHIFT
approved these changes
Mar 11, 2024
XuNeo
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thank you!
As a reference: http://elm-chan.org/fsw/ff/doc/readdir.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fs_dir_read function not takes into account the end of the entries, since it never finishes reading the next one, thus entering a loop (#5823).
Description of the feature or fix
fix to exit loop upon reaching last entry
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.