New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add Chinese translation (jump link) #5839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Some minor changes needed
- Sorry, but I think we should show the external link ( https://lvgl.100ask.net/ ) on the home page, or in header/footer instead of adding same
link_to_translation
to every doc file. New doc files will not contain it (ppl might forget to add), and btw there could be other translations too, not only chinese, so having a link in header/footer/sidenav to external sites with the translations is better.
Good suggestion! I will improve it today. |
What do you think? @kisvegabor |
de71be2
to
e29d35b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes, thanks, only some minor comments are added.
PS:
you don't have to squash commits in your branch, simply add a new commit, so reviewers can see what is changed since last review (since last commit).
Then after PR is approved, we do a squash merge, and in the end only 1 commit will go to master
branch. But till then it is good to see all commits and change commits in feature branch.
|
I think it's appropriate to put it at the beginning of the text: |
Yes, I think at the moment it is enough to add to top of page (like in ESP-IDF), so later we might implement other option. (I personally prefer having a language selector dropdown / button on top of sidenav, or top-right of page, that we don't need to search, and does not reserve/waste too much space on screen) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unlikely that we will add more translations in the future due to maintenance issues. China is special because:
- We have a lot of users in China
- Many people don't know English
- Websites outside of China are super slow
I created this PR with a new branch, the old PR: #5750