Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(group): remove useless code #6124

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

kisvegabor
Copy link
Member

fixes #5955

Description of the feature or fix

A clear and concise description of what the bug or new feature is.

Notes

@lvgl-bot
Copy link

We need some feedback on this pull request.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

Copy link
Collaborator

@XuNeo XuNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks not that straight forward. Awesome if you could explain a bit :)

@kisvegabor
Copy link
Member Author

Sure! We call lv_group_remove_obj(obj); first, so we can be sure that the object is not in the group after that anymore. Therefore the two removed sections are pointless:

    /*Do not add the object twice*/   -->  It's already removed cannot be added twice
    /*If the object is already in a group and focused then refocus it*/ --> Removed, cannot be in the group

@kisvegabor kisvegabor merged commit c061277 into lvgl:master May 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LVGL 9 lv_group_add_obj unecessary steps?
5 participants