feat(property): add property name #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FASTSHIFT
reviewed
Jun 6, 2024
Property ID contains the property index number and property type. Check if the property index is in range or not. Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
XuNeo
force-pushed
the
property-name
branch
2 times, most recently
from
0975b05
to
6b311c2
Compare
W-Mai
approved these changes
Jun 10, 2024
|
LGTM |
kisvegabor
reviewed
Jun 11, 2024
|
It seems to be very useful for us with the editor too. It looks good to me, but @coevin @liamHowatt and @richardgazdik could you also take look at it? |
liamHowatt
reviewed
Jun 12, 2024
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Since now lv_point_t is a basic property value type, pivot can be treated as a normal value instead of void * pointer. Add a test for it Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
kisvegabor
reviewed
Jun 13, 2024
| {"flag_checkable", LV_PROPERTY_OBJ_FLAG_CHECKABLE,}, | ||
| {"flag_click_focusable", LV_PROPERTY_OBJ_FLAG_CLICK_FOCUSABLE,}, | ||
| {"flag_clickable", LV_PROPERTY_OBJ_FLAG_CLICKABLE,}, | ||
| {"flag_end", LV_PROPERTY_OBJ_FLAG_END,}, |
There was a problem hiding this comment.
Are you concerned about the flash size? flag is treated as a property so it's automatically included here. Maybe we should remove the flag property totally?
XuNeo
commented
Jun 17, 2024
| {"flag_checkable", LV_PROPERTY_OBJ_FLAG_CHECKABLE,}, | ||
| {"flag_click_focusable", LV_PROPERTY_OBJ_FLAG_CLICK_FOCUSABLE,}, | ||
| {"flag_clickable", LV_PROPERTY_OBJ_FLAG_CLICKABLE,}, | ||
| {"flag_end", LV_PROPERTY_OBJ_FLAG_END,}, |
There was a problem hiding this comment.
Are you concerned about the flash size? flag is treated as a property so it's automatically included here. Maybe we should remove the flag property totally?
liamHowatt
approved these changes
Jun 17, 2024
FASTSHIFT
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Binding language like
luaorjsprefer to use name to set property.This patch is one of the series to make bindings easier to set widget property.
Added a table to convert property name to ID. The name table is generated automatically though
properties.pyscript, based on the property ID definitions.If the name is not provided for specified widget, then recursively looking up its base classes.
bsearchis used to match up strings.The test has passed.
This API is experimental and is subject to change if binding language requires differently.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.