Feat/ssd1306 partial update #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For monochrome displays each byte of the buffer size can store data for 8 pixels. We divide LV_VER_RES_MAX by 8 because the display vertical side is grouped in pages of 1 byte, so we need 1byte times LV_HOR_RES_MAX to represent the data of one page.
kisvegabor
reviewed
Jan 21, 2021
|
d504887 changes the display buffer size, from 8192 to 1024 bytes when using the 128*64 px display. As far as I know, the display buffer for monochrome displays should be "in pixels", am I right? |
Yes, it's in pixels. So 128 x 64 / 8 = 1 kB is correct. |
|
This is ready to be reviewed, I choosed assert over error handling on data transmission because it shouldn't fail. |
embeddedt
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've working on improving the SSD1306 display driver, hopefully this changes also help us to start working on the MCU independent drivers.
TO DO: