Fix contrast and display mode initialisation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double byte command OLED_CMD_SET_CONTRAST (SSD1306 datasheet rev 1.1 p.28) was followed by display_mode. So the contrast was set to 0xA6 or 0xA7 depending on the display mode configured and the display mode itself wasn't configurable.
Fix contrast and display mode initialisation
|
Thanks for the patience @Alnef and @tore-espressif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the fix
The double byte command OLED_CMD_SET_CONTRAST (SSD1306 datasheet rev 1.1 p.28) was followed by display_mode.
So the contrast was set to 0xA6 or 0xA7 depending on the display mode configured and the display mode itself wasn't configurable.
See the issue #53 for more details.