[Bug] Calling a value is not thread safe (return another value)

[Amerousful]

I noticed that when calling values ​​from different threads, it can returns values ​​from other methods. The wrong method is invoked somehow. Bug reproduced on version 1.0.11
I tried 1.0.8 - 1.0.10 and all ok.

src/test/resources/config.properties

firstName=Pasha
lastName=Bairov

---

import org.aeonbits.owner.Config;

@Config.Sources({"file:src/test/resources/config.properties"})
public interface MyConfig extends Config {

    @Key("firstName")
    String firstName();

    @Key("lastName")
    String lastName();
}

---

public static void main(String[] args) {
        MyConfig cfg = ConfigFactory.create(MyConfig.class);


        new Thread(() -> {
            for (int i = 0; i < 1000; i++) {
                String name = cfg.firstName();

                if (!name.equals("Pasha")) {
                    System.out.println("name " + name);
                }
            }
        }).start();

        new Thread(() -> {
            for (int i = 0; i < 1000; i++) {
                cfg.lastName();
            }
        }).start();
    }

---

I executed it 1000 times and here it stdout:

name Bairov
name Bairov
name Bairov
name Bairov
name Bairov

---

I can provide any necessary information for debugging.

[lviggiano]

This is ugly. Thanks for the bug report.

I really need to take back my hands on this project.

[lviggiano]

There are few patched added from 1.0.10 to 1.0.11, so what we can do is to repeat your test for every code change, and verify what is the patch that introduced the bug, then find the fix.
If you happen to find more, please let me know.
I'll try to get this fixed.

[lviggiano]

it looks like the problem has been introduced by commit 1acb314

[lviggiano]

which in turn, is the merge of #255 #254

[lviggiano]

I released 1.0.12, this should fix the issue. Let me know.

[lviggiano]

thank you for the unit test, really appreciated you took the time to produce a test case to reproduce the issue. I wrote a unit test inspired to your code. So this issue hopefully will not show up again.

[Amerousful]

I was very glad to help!
Thanks for the quick response and fix. I will wait the new version.

I wanted to write the test by myself but you was faster than me :)

[lviggiano]

@Amerousful It's already released. 1.0.12, try that out and let me know.

[Amerousful]

@lviggiano Yes, it works fine! Thanks!

[lviggiano]

@Amerousful Glad it helped. Thank you for your valuable time in helping.