Thread contention on Converters.PROPERTY_EDITOR

[raulcaj]

Hi!

There is a problem of thread contention on the PropertyEditorManager.findEditor. It loads classes from the ClassLoader switch is a thread blocking operation.

Is it possible to cache this method result so it wouldn't be called again or it would break this functionality somehow?

It would go something like this:

			@Override
			Object tryConvert(Method targetMethod, Class<?> targetType, String text) {
				if (!canUsePropertyEditors())
					return SKIP;
				PropertyEditor editor = PROPERTY_BY_CLASS.get(targetType);
				if (editor == null) {
					editor = PropertyEditorManager.findEditor(targetType);
					if (editor != null)
						PROPERTY_BY_CLASS.put(targetType, editor);
				}
				if (editor == null)
					return SKIP;
				try {
					editor.setAsText(text);
					return editor.getValue();
				} catch (Exception e) {
					throw unsupportedConversion(e, targetType, text);
				}
			}

[lviggiano]

@raulcaj The classloader does cache by itself, indeed. Try doing some benchmark to verify.

[lviggiano]

how did you verify that there is thread contention? I've not looked yet into it, but I know for sure that the classloader does caching.

can you please elaborate your evidences about this?

[raulcaj]

@lviggiano report
I had done a report for the company I work for. I'm sharing it with you.

[raulcaj]

also, I'd like to add that the result of isClassAvailable method should be cached too.

[lviggiano]

ok then, sounds fine. If you want to send me a pull request I'll merge that.

[raulcaj]

Great! I'll just finish running some more tests to see if I catch something else related to this and I'll create it.

[lviggiano]

Thanks for the report; the improvement looks impressive.
I'll try to roll out a new version asap.

It's long time I'm not doing active development on this project, I need to cleanup two things, then I hope it won't take much time to release a new version on maven repository.

Today afternoon I was fighting with maven+intellij since I was not using my laptop at home for development.

[lviggiano]

solved by #255