Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the comment about routing incorrect? #61

Closed
patefacio opened this issue Aug 16, 2014 · 1 comment
Closed

Is the comment about routing incorrect? #61

patefacio opened this issue Aug 16, 2014 · 1 comment

Comments

@patefacio
Copy link

It gives an example of route "/hello/:firstname.:lastname?" and claims it will match "/hello/john" and "/hello/john.doe". While it does match the latter, it is accepting all of 'john.doe' as firstname which is either incorrect or very confusing.

@lvivski
Copy link
Owner

lvivski commented Aug 16, 2014

thanks, this issue was introduced recently with a bad regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants