Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the way the files are included. #14

Merged
merged 4 commits into from
May 7, 2013

Conversation

enyo
Copy link
Contributor

@enyo enyo commented May 4, 2013

This follows my issue #11 .

I think it's more "dart like" to build the framework like this and it allows for proper typing like this:

start(view: new View()).then((Server app) {
    app.get('/', (Request req, Response res) {
      // Do stuff
    });
});

without having to import all files separately.

enyo added 4 commits May 4, 2013 19:08
…art.

This way it's 1) more efficient, 2) allows the editor to auto complete, and 3) works with the latest dart version.
Also moved lib/server to lib/src/server since it's already exposed as part anyway.
dart_analyzer resolves parts automatically so there's no need to call it for every .dart file

If called on every dart file it crashes now, since the imports aren't properly resolved.
lvivski added a commit that referenced this pull request May 7, 2013
Refactored the way the files are included.
@lvivski lvivski merged commit d459266 into lvivski:master May 7, 2013
@enyo enyo deleted the import-part branch May 7, 2013 11:49
@bsjung bsjung mentioned this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants