Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading first 2 lessons #7

Merged
merged 2 commits into from Mar 27, 2015
Merged

Proofreading first 2 lessons #7

merged 2 commits into from Mar 27, 2015

Conversation

qjcg
Copy link

@qjcg qjcg commented Mar 27, 2015

I tried to focus on:

Feedback welcome!

@lwasser
Copy link
Owner

lwasser commented Mar 27, 2015

hey. this is great - thank you. Quick question before i merge. It looks like all of the lines were shortened including the paragraphs of text. i'm curious about that given at some point we'll render MD --> html and the width will be constrained by CSS. is this just how SWC and DC format MD files? and will it translate to HTML when rendered with Jekyll?

i'm just wondering how that part works. Thanks John!

@tracykteal
Copy link

The Markdown will render in HTML, basically just how it looks as Markdown. The line breaks won't show up. Sometimes it's nice to have the line breaks for diffs for just one line, but it's not required.

@lwasser
Copy link
Owner

lwasser commented Mar 27, 2015

Ahh ok cool. got it. good to know.
I'll merge this now. Tracy, do you want me to build this as a gh-pages branch too at some point so when we merge, you can have a site page like SWC does?

lwasser pushed a commit that referenced this pull request Mar 27, 2015
Merging John's edits into the repo!! Proofreading first 2 lessons
@lwasser lwasser merged commit b3ecb52 into lwasser:master Mar 27, 2015
@tracykteal
Copy link

Yes, it would be good to have it in the gh-pages branch. Thanks!

@lwasser
Copy link
Owner

lwasser commented Mar 27, 2015

ok! I'll build that out after john's done with his edits!
Leah

fmichonneau pushed a commit to fmichonneau/python-ecology that referenced this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants