Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-arch images with Github Actions #95

Merged
merged 1 commit into from
May 29, 2024
Merged

Multi-arch images with Github Actions #95

merged 1 commit into from
May 29, 2024

Conversation

awilmore
Copy link
Contributor

@awilmore awilmore commented May 27, 2024

Hi @lwolf,

I've created two Github actions that should do the job of replacing Travis:

  • test.yml : runs on pull request creation and simply runs make test at this stage
  • release.yml : runs on tag creation, and uses GoReleaser to build and push multi-arch images and manifests

Caveat - this is my first time using GoReleaser. I tested this using my dockerhub login and it seems to work okay: https://hub.docker.com/r/awilmore/kube-cleanup-operator/tags

The github action requires that you set the values for QUAY_USERNAME and QUAY_PASSWORD as action secrets here: https://github.com/lwolf/kube-cleanup-operator/settings/secrets/actions

That's about it. I hope this is enough info to get this set up as your Travis replacement.

UPDATE

This PR addresses:

@lwolf
Copy link
Owner

lwolf commented May 29, 2024

thanks. looks good. let's try it...

@lwolf lwolf merged commit 5daa877 into lwolf:master May 29, 2024
@lwolf
Copy link
Owner

lwolf commented May 29, 2024

it did work, but there are a couple of things:

  1. the resulting image was tagges as quay.io/lwolf/kube-cleanup-operator:0.8.4 (should be v0.8.4). I'll update .goreleaser to prepend v` before the {{version}}

The other thing is that goreleased haven't added the images to the release description (but to be honest I don't remember if it ever did that or I was adding it manually all the time).

Anyway thanks again!

@awilmore
Copy link
Contributor Author

Thanks @lwolf 🙏

@awilmore awilmore deleted the cicd branch May 30, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants