Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The setting is not reflected when the shift key is pressed in the key setting. #243

Closed
hokuto-kato opened this issue Apr 17, 2020 · 5 comments
Closed

The setting is not reflected when the shift key is pressed in the key setting. #243

hokuto-kato opened this issue Apr 17, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@hokuto-kato
Copy link

It looks like this.
out
lwouis added a commit that referenced this issue Apr 18, 2020
@lwouis
feat: allow shortcuts to be modifiers-only (closes #243)
67b6f43
@lwouis
Copy link
Owner

lwouis commented Apr 18, 2020

Hi @hokut-o! Thank you for sharing this issue!

This is intended behavior. The first shortcut accept modifier keys only. For example alt or alt+cmd. The 3 shortcuts on the right accept either non-modifier key like tab or t, or mix-keys like shift+tab or shift+t. They don't accept modifiers-only like shift.

That being said, I tried to remember why these restrictions exist and couldn't find a good reason. I made the change to allow what you want locally and I couldn't find a problem with that.

I will release an update that allow your use-case today 👍

Note: It seems that you have your mac set with the Japanese language. It looks a bit freaky with half in Japanese and half in English.

If you want to help localize the app in Japanese, you can just go to here and type the correct Japanese text. It's very easy and fast 💯

@lwouis lwouis added the enhancement New feature or request label Apr 18, 2020
@lwouis lwouis closed this as completed in d4be095 Apr 18, 2020
lwouis pushed a commit that referenced this issue Apr 18, 2020
@semantic-release-bot
chore(release): 3.9.0 [skip ci]
935d556 
# [3.9.0](v3.8.0...v3.9.0) (2020-04-18)

### Features

* allow shortcuts to be modifiers-only (closes [#243](#243)) ([d4be095](d4be095))
@hokuto-kato
Copy link
Author

Hi @lwouis . Thanks for the quick reply and improvement!
I would like to participate in a translation project.
I was able to log in.
image

@hokuto-kato
Copy link
Author

I was able to access the edit page.
Thank you.

@lwouis
Copy link
Owner

lwouis commented Apr 19, 2020

@hokut-o cool :)

By the way, did the new release of AltTab fix your issue?

@hokuto-kato
Copy link
Author

@lwouis
I've solved the issue!
Thanks for the quick resolution:grin::+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwouis @hokuto-kato