Cross-compile armv7l binaries for 32-bit Raspberry Pi's #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add patch based on curl/curl#9054
lwthiker
reviewed
Jul 15, 2023
Makefile.in
Outdated
| @@ -380,11 +381,16 @@ $(CURL_VERSION)/.firefox: $(firefox_libs) $(CURL_VERSION).tar.xz $(CURL_VERSION) | |||
| fi; \ | |||
| add_cflags="-I$(nss_install_dir)/../public/nss"; \ | |||
| add_cflags+=" -I$(nss_install_dir)/include/nspr"; \ | |||
| if test "$(host_cpu)" = "arm"; then \ | |||
| add_libs="-L$(nss_install_dir)/lib -l:libgcm-aes-arm32-neon_c_lib.a"; \ | |||
There was a problem hiding this comment.
I think this should go in the curl patch file, look for the patch to libcurl.pc.in where these flags are set.
lwthiker
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though Raspberry Pi OS supports 64-bit with architecture aarch64, there are still users of the 32-bit OS with architecture armv7l. This change adds cross-compilation targeting the 32-bit armv7l architecture with a few tweaks:
easy_lock.h(this has been fixed upstream in curl 7.85+)I built the cross-compiled binaries locally with these changes and tested them on a Raspberry Pi 3b+ running 32-bit Raspbian bullseye.