Added new option to delete old log entries.

lx-s · Aug 13, 2020 · dc1c7ad · dc1c7ad
1 parent 343684b
commit dc1c7ad
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/config.sample.php b/config.sample.php
@@ -22,7 +22,10 @@
   // see contents of translations directory
   define('CCL_LANG', 'en');
 
-  define('ENTRY_LOG_DAYS', 3 * 7); // Last 3 weeks
+  // Last 3 weeks
+  define('ENTRY_LOG_DAYS', 3 * 7);
+  // When set to false, entries oder than ENTRY_LOG_DAYS are deleted
+  define('KEEP_OLD_ENTRIES', false);
 
   /* If the user array has at least one entry, this site
      can only be accessed by using proper credentials.

diff --git a/index.php b/index.php
@@ -24,14 +24,34 @@ function add_entry($who)
       if ($stmt->execute() === true) {
         $added = true;
       } else {
-        $errors[] = _tr('sql.error.insert').': <code>'.get_sql_error($db_).'</code>';
+        $errors[] = _tr('sql.error.insert').': <code>'.get_sql_error($stmt).'</code>';
       }
       $stmt->closeCursor();
     }
 
     return $added;
   }
 
+  function delete_old_entries()
+  {
+    if (defined('KEEP_OLD_ENTRIES') && KEEP_OLD_ENTRIES === false) {
+      global $db_;
+      global $errors;
+      $sql = 'DELETE FROM '.DB_TABLE_PREFIX.'contact_log'
+            .' WHERE time < NOW() - INTERVAL :days DAY';
+      $stmt = $db_->prepare($sql);
+      if ($stmt === false) {
+        $errors[] = _tr('sql.error.prepare').': <code>'.get_sql_error($db_).'</code>';
+      } else {
+        $stmt->bindValue(':days', ENTRY_LOG_DAYS, \PDO::PARAM_INT);
+        if ($stmt->execute() === false) {
+          $errors[] = _tr('sql.error.query').': <code>'.get_sql_error($stmt).'</code>';
+        }
+        $stmt->closeCursor();
+      }
+    }
+  }
+
   function get_entries($lastDays)
   {
     global $db_;
@@ -45,9 +65,9 @@ function get_entries($lastDays)
     if ($stmt === false) {
       $errors[] = _tr('sql.error.prepare').': <code>'.get_sql_error($db_).'</code>';
     } else {
-      $stmt->bindValue(':days', $lastDays);
+      $stmt->bindValue(':days', $lastDays, \PDO::PARAM_INT);
       if ($stmt->execute() === false || ($results = $stmt->fetchAll(\PDO::FETCH_ASSOC)) === false) {
-        $errors[] = _tr('sql.error.query').': <code>'.get_sql_error($db_).'</code>';
+        $errors[] = _tr('sql.error.query').': <code>'.get_sql_error($stmt).'</code>';
       }
       $stmt->closeCursor();
     }
@@ -66,6 +86,7 @@ function get_entries($lastDays)
     }
   }
 
+  delete_old_entries();
   $entries = get_entries(ENTRY_LOG_DAYS);
 
 ?><!doctype html>