Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: command line changes #60

Closed
brauner opened this issue Mar 14, 2018 · 2 comments
Closed

RFC: command line changes #60

brauner opened this issue Mar 14, 2018 · 2 comments

Comments

@brauner
Copy link
Member

brauner commented Mar 14, 2018

This is really just a question whether replacing:

Available Commands:
  build-dir   Build plain rootfs
  build-lxc   Build LXC image from scratch
  build-lxd   Build LXD image from scratch
  help        Help about any command
  pack-lxc    Create LXC image from existing rootfs
  pack-lxd    Create LXD image from existing rootfs

should be

Available Commands:
  build dir   Build plain rootfs
  build lxc   Build LXC image from scratch
  build lxd   Build LXD image from scratch
  help        Help about any command
  pack lxc    Create LXC image from existing rootfs
  pack lxd    Create LXD image from existing rootfs

It seems cleaner to me but feel free to close this without discussing it if you think that it doesn't make sense. :)

@stgraber
Copy link
Member

I usually prefer your proposed syntax though in this case, I'm not sure that it actually makes sense.

The reason is that build-dir, build-lxc and build-lxd aren't actually related. There isn't a "build" object that then has "dir", "lxc" and "lxd" actions against it, as is the case with the lxc command in LXD.

The same goes for the pack command.

@stgraber
Copy link
Member

What we could have done is just have the "build" and "pack" commands and then make the target an argument, but that would have made arguments and flags validation annoying as those vary based on the target, so separate commands was making that quite a bit easier.

@brauner brauner closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants