systemd: Don't bring network down when using routed networking #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Could you please sign-off your commit, and add a proper commit description? |
My google-fu is failing me, how do I sign off an already submitted pull request? Or do I have to submit a new one? |
|
You need to run |
nic together with NetworkManager, as in this case networking is configured externally by lxd. fixes lxc/lxc-ci#776 Signed-off-by: Aleksandar Ivanišević <alex@2e-systems.com>
stgraber
changed the title
stgraber
approved these changes
Aug 3, 2023
|
If you don't mind me asking, how long until images in images: are going to be built with this included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not bring the networking down on container startup when using routed nic together with NetworkManager, as in this case networking is configured externally by lxd.
Signed-off-by: Aleksandar Ivanisevic aleksandar@ivanisevic.de