-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend completion logic to include alias commands #738
Comments
We may be able to complete the alias names but with the new logic, we won't be able to complete the actual arguments for those. @adamcstephens is that something you think you could sort out? Expanding the top level completion logic to also consider what's defined as aliases in the config. |
The reason it worked before was that the logic was hard-coded in the hand written profile. I'm actually surprised that we did that given that the user could have removed or modified that alias, breaking the completion logic. |
Yes I can look into this. |
Really annoying that So, what you're saying is that it's impossible to complete container names for the |
It may be possible to special case it in the completion logic, so if the |
I looked at this some last night. It may be possible to intercept completion requests for aliases and re-call the binary with the target completion. These aliases are handled outside the cobra command environment though so I don’t think we can use it at all. |
Thank you! |
Much much appreciated that you were able to bring this back, thanks a lot! 🙇 ❤️ |
Required information
Issue description
Hi! and congratulations for this release!
During the 0.x cycle :
incus shell
would autocomplete as a commandincus shell
would autocomplete the instance nameAlso, access to an instance was a tad quicker, especially with remote containers. But may be it's just me...
I am aware that this is now an alias.
Coming from the systemD-nspawn world, this was a very nice feature; very quick to get into an instance, much like
machinectl shell <instance>
.Thank you for all the work! This software is awesome!
Steps to reproduce
Information to attach
None.
The text was updated successfully, but these errors were encountered: